search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
13 stars 5 forks source link

Update Java module names #66

Closed ielis closed 2 years ago

ielis commented 2 years ago

The PR contains updates of the module-info.java files. The module names are changed to stem from org.phenopackets.phenopackettools. The version of the phenopacket-schema is bumped to v2.0.2.

There is one thing I am not certain about in the module-info.java of the builder module. Should we require com.google.protobuf in a transitive way? There is already a transitive requirement for org.phenopacket.schema, which requires protobuf. However, the TimestampBuilder includes Timestamp in the API independently of the protobuf, so maybe the transitive requirement is appropriate here too. I'll investigate this further.

ielis commented 2 years ago

The changes will be included in another PR.