phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
13 stars 5 forks source link

rareDiseaseValidation #71

Closed pnrobinson closed 2 years ago

pnrobinson commented 2 years ago

I do not think the following belongs in ValidatorInfo. The rare disease file is a very short example of how to add a second JSON Schema but it does not represent a general validator for rare diseases. I think it should be moved as an example to the CLI

 /**
     * This class implements additional validation of a phenopacket that is intended to be used
     * for HPO rare disease phenotyping. By assumption, the phenopacket will have been first
     * checked against the {@link ValidatorInfo#generic()} specification. This class performs validation with the
     * file {@code hpo-rare-disease-schema.json}.
     */
    static ValidatorInfo rareDiseaseValidation() {
        return DefaultValidationInfo.rareDiseaseValidator();
    }
pnrobinson commented 2 years ago

done