search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
13 stars 5 forks source link

ValidationMessage #80

Closed pnrobinson closed 2 years ago

pnrobinson commented 2 years ago

Hi @ielis @julesjacobsen , I am seeing that 

public JsonValidationError(ValidatorInfo validatorInfo, ValidationMessage validationMessage) {

is using this class

import com.networknt.schema.ValidationMessage;

while the class seems fine, it is relatively simple and does not seem to justify us adding this external dependency. Is there any reason for using this?

pnrobinson commented 2 years ago

This class is from the Json schema library and we need to keep it, but we will not expose it in our API