search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

Bump JSON Schema version #92

Closed pnrobinson closed 1 year ago

pnrobinson commented 2 years ago

https://github.com/networknt/json-schema-validator

V2020-12 -- our schema should be identical, but now networknt supports latest JSON Schema version

pnrobinson commented 1 year ago

@ielis Should we update?

ielis commented 1 year ago

The JSON Schema 2020-12 Release Notes highlights the changes between Draft 2019-09 and Draft 2020-12.

There should be no issues with updating our schemas, because the changes do not affect our schemas. However, the authors of json-schema-validator, the library we use to validate phenopackets under the hood, are still working on correct implementation.

In other words, if I update the $schemas to 2020-12 and use SpecVersion.VersionFlag.V202012, the tests fail. Specifically, all tests that validate an array member (e.g. one of phenotypic features).

I don't think we should update schema for the next release, let's stick with Draft 2019-09.