Closed pnrobinson closed 1 year ago
Hi @pnrobinson, I went through the V1->V2 code and I think it's almost ready to go. As you know, it is fairly straightforward to convert almost everything except for genes
, variants
, and part of Biosample
in the v1 phenopackets.
There are 3 outstanding issues:
Variant
into GenomicInterpretation
and creates one Interpretation
for a given v1 Disease
.VariationDescriptor
Variant
field in v2 Biosample
. Do we omit the Variant
s from v1 Biosample
? This will likely do little if any damage, right?Other than this, I think we can wrap this up.
SPDI allele is now turned into a VRS Expression
using the VariationDescriptorBuilder.spdi()
method.
@ielis @julesjacobsen -- this is a v1 to v2 converted that assumes that the v1 phenopacket variant is causal for the disease and that the v1 phenopacket has exactly one disease. I am not sure how to convert SPDI variants but probably via VRS objects.