phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

convert v1 variants #95

Closed pnrobinson closed 1 year ago

pnrobinson commented 1 year ago

@ielis @julesjacobsen -- this is a v1 to v2 converted that assumes that the v1 phenopacket variant is causal for the disease and that the v1 phenopacket has exactly one disease. I am not sure how to convert SPDI variants but probably via VRS objects.

ielis commented 1 year ago

Hi @pnrobinson, I went through the V1->V2 code and I think it's almost ready to go. As you know, it is fairly straightforward to convert almost everything except for genes, variants, and part of Biosample in the v1 phenopackets.

There are 3 outstanding issues:

Other than this, I think we can wrap this up.

ielis commented 1 year ago

SPDI allele is now turned into a VRS Expression using the VariationDescriptorBuilder.spdi() method.