phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

Develop #99

Closed pnrobinson closed 1 year ago

pnrobinson commented 1 year ago

@ielis please take a look at validate.rst

hrshdhgd commented 1 year ago

@pnrobinson , I have added a new page for examples. It is very basic as of now and doesn't include cohorts since there are no YAML files generated under that directory.

@ielis , for now I have implemented a simple find jar in phenopacket-tools-cli/target/ directory and it seems to work fine. We can always think of better ways to do this if need be.

pnrobinson commented 1 year ago

@hrshdhgd not sure how to test this without actually merging. Should we go ahead and then make any additional changes later on?

hrshdhgd commented 1 year ago

I have it such that it publishes the documentation after every commit to this branch. So the documentation you see here is how we test. Before merging the branch, we will have to change the pages.yaml line # 9 to read main instead of develop

hrshdhgd commented 1 year ago

Future branch changes will only reflect in the documentation when they are merged to main

ielis commented 1 year ago

I am converting this to a draft, because we should not really be doing a PR like this. A merge from develop to main happens through a release branch. Let's keep this draft around until we figure out what exactly needs to be accomplished.