phenopackets / phenopacket-validator

Library and tools to help validate phenopackets
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Finish refactor #21

Closed ielis closed 3 years ago

ielis commented 3 years ago

Hi @pnrobinson

These are the changes I propose. The most important thing is the work on HpoValidator; I implemented the remaining logic tests and I also added tests.

I bumped the validator to Java 16, allowing to use records as default implementations of e.g. ValidationItem. I also added several utility classes that serve "static constants" (e.g. ValidationItemTypes.syntaxError(), JsonValidationItemTypes, and OntologyValidationItemTypes).

Finally, I removed a lot of boilerplate from POMs. I think we are getting closer to have a good API and a prototype CLI app. Let's touch bases soon on the overall plan of the CLI, and what it should support.