search

phenopolis / phenopolis_genomics_browser

Python API and React frontend for the Phenopolis Genomics Browser
https://dev-live.phenopolis.org
MIT License
31 stars 2 forks source link

Replace loading with Skeleton #265

Closed IsmailM closed 3 years ago

IsmailM commented 3 years ago

Due: 30/05/2021

It should be easy...

IsmailM commented 3 years ago

Migrated from https://github.com/phenopolis/phenopolis_frontend_react/issues/252#issuecomment-703328909 Originally created by @IsmailM on Sun, 04 Oct 2020 23:06:11 GMT

I remember looking into this. The only thing to remember is that we also need to use the ready variable from i18next useTranslation hook

See https://react.i18next.com/latest/usetranslation-hook#not-using-suspense

pontikos commented 3 years ago

@YuanTian1991 any updates on this please?

YuanTian1991 commented 3 years ago

I have not done that. Will find time to do it.