Closed logust79 closed 3 years ago
Agree, @Tian Yuan tian.yuan@phenopolis.org can you do this please?
On Fri, 18 Dec 2020 at 13:07, logust79 notifications@github.com wrote:
Would be good to have a button or link to the create_patient page on the my_patients page.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phenopolis/phenopolis_browser/issues/303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5MN5BBI3RCUXY6QOUUG6DSVNHZ3ANCNFSM4VBE5ECA .
I think only Admin can create user? That's why I specifically did not put button in my_patient page. The only way to create user is in manage_patient page, which is Admin only.
In my idea, my_patient page is used to show all accessible patient (only to view). Also, I want to have 3 other pages for gene, hpo, variants.
I also think there should be button on that page for admins. Or a shortcut button.
On Fri, 18 Dec 2020, 14:30 Yuan Tian, notifications@github.com wrote:
I think only Admin can create user? That's why I specifically did not put button in my_patient page. The only way to create user is in manage_patient page, which is Admin only.
In my idea, my_patient page is used to show all accessible patient (only to view). Also, I want to have 3 other pages for gene, hpo, variants.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/phenopolis/phenopolis_browser/issues/303#issuecomment-748113938, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5MN5DVYHXVFNUSMJ52NGDSVNRQXANCNFSM4VBE5ECA .
OK, I will add a button, only visible for Admin user.
I also think it should be possibel to upload files and delete patients from that page using the edit button. I don't like to have to go to another part of the website to manage patients.
@YuanTian1991 can you implement this please and close issue?
@alanwilter @YuanTian1991 I understand there has been some issues fixing this that you have discussed on Slack. Can you please provide a succint update here on what the issues are so we are all on the same page?
I need to sort #352 and #169 first for @YuanTian1991. I'm working on genes now.
To summarise:
However, I need to check which conflicts these actions may have with refactoring of the code for migrating to new schema. I won't invest time creating endpoints that may still use the old schema.
see #242
@YuanTian1991 for demo you need to handle 405 {"error":"Demo user not authorised"}
message
Fixed this bug.
Should we close it then?
Would be good to have a button or link to the
create_patient
page on themy_patients
page.