search

phenopolis / phenopolis_genomics_browser

Python API and React frontend for the Phenopolis Genomics Browser
https://dev-live.phenopolis.org
MIT License
31 stars 2 forks source link

"Can not Fetch preview information" message should be "You are not permitted to view this patient" #361

Open pontikos opened 3 years ago

pontikos commented 3 years ago

"Can not Fetch preview information" 404

shoudl be replace by "You are not permitted to view this patient" 403

this is for demo user

image

alanwilter commented 2 years ago

I can change that but we will need some change also in the JS side, in files like ...phenopolis_browser/frontend/src/redux/actions/gene.js, ...phenopolis_browser/frontend/src/serviceWorker.js etc.

alanwilter commented 2 years ago

The reasoning to use 404 instead of 403, if I remember well, was from Daniele, to avoid giving the idea to users that they may hack our app because the data is there in the end.