search

phenopolis / phenopolis_genomics_browser

Python API and React frontend for the Phenopolis Genomics Browser
https://dev-live.phenopolis.org
MIT License
31 stars 2 forks source link

Migration of autocomplete to new DB schema #375

Closed alanwilter closed 2 years ago

alanwilter commented 3 years ago

Considering it to MERGE

I've completed the migration. AFAIK the only tables lingering from old schema (public) are actually actively used in the new schema:

What should we do about them? Whatever decided, to be dealt in another PR.

netlify[bot] commented 3 years ago

✔️ Deploy Preview for phenopolis-dev canceled.

🔨 Explore the source changes: 5a570abda705e29c3632768a992e53857ed3d27f

🔍 Inspect the deploy log: https://app.netlify.com/sites/phenopolis-dev/deploys/618118303923320007fa1b40

pontikos commented 2 years ago

Agree should point to local file as first time users are unlikely to have AWS or may not be allowed to put data on AWS.

On Fri, 29 Oct 2021, 07:51 Ismail Moghul, @.***> wrote:

@.**** commented on this pull request.

In public.env https://github.com/phenopolis/phenopolis_genomics_browser/pull/375#discussion_r738975151 :

@@ -8,8 +8,6 @@ PH_DB_PORT=5432

S3_VCF_FILE_URL="s3://phenopolis-vcf/August2019/merged2.vcf.gz"

We should replace this with a link to a local file

(or ideally an S3 link to a file on a local MinIO instance...)

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/phenopolis/phenopolis_genomics_browser/pull/375#pullrequestreview-792678668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5MN5FMSZ2WGMIK5JYU6RLUJJG7PANCNFSM5AM3HGNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.