search

phenoscape / phenoscape-kb-ui

Phenoscape KB web user interface.
MIT License
1 stars 1 forks source link

Added loading wheel and fixed DOM elements #104

Closed Lucytheanimefan closed 8 years ago

Lucytheanimefan commented 8 years ago

Enabled drilling down on graph, added css styling, and incorporated other more recent updates such as clickable x-axis labels

hlapp commented 8 years ago

@balhoff feel free to use this as an opportunity to provide code review comments.

balhoff commented 8 years ago

@Lucytheanimefan looking nice! The most immediate piece of feedback I have is wondering whether you can draw the graphs within a particular DOM element. Right now they are being appended to the end of the page after the footer. The function where the drawing is implemented gets 3 arguments: link: function(scope, element, attrs). All the content for this directive should go inside of element. Is that an easy fix?

balhoff commented 8 years ago

It would be nice to add a scope variable where you could set true or false if the graph is busy retrieving data. The app could watch this variable and put up a busy indicator (you don't need to put this functionality in your directive).

hlapp commented 8 years ago

@balhoff can you comment whether you consider this ready for merge now?

balhoff commented 8 years ago

@Lucytheanimefan nice fixes! The graphs are placed where I expect now.