search

phenoscape / pipeline

Build pipeline for the Phenoscape Knowledgebase
MIT License
0 stars 0 forks source link

Test Makefile using placeholder scripts #216

Closed johnbradley closed 2 years ago

johnbradley commented 2 years ago

Adds test/test-makefile.sh script to test the Makefile. Adds test/bin/* placeholder scripts that simulate the various commands used by the Makefile. Adds a github action to run the test on push.

Fixes #214

Creating a Draft PR to get feedback on this approach to testing just the Makefile. I wrote the placeholder scripts in node to avoid conflicts with the programs being run by the Makefile and because node makes it easy to parse differing command line arguments.

johnbradley commented 2 years ago

Something to notes is the Makefile needs a GNU sed command to run. On my Mac I had errors due to the sed -i flag working differently. To fix this when testing on a Mac I temporarily put a GNU sed in my path.

balhoff commented 2 years ago

Something to notes is the Makefile needs a GNU sed command to run. On my Mac I had errors due to the sed -i flag working differently. To fix this when testing on a Mac I temporarily put a GNU sed in my path.

@johnbradley I think we could remove usages of -i I just output to a new file. Would that work?

johnbradley commented 2 years ago

@johnbradley I think we could remove usages of -i I just output to a new file. Would that work?

@balhoff I think that's the only feature that's not compatible with the Mac sed. Would you like me to rework the sed commands to not use -i?

balhoff commented 2 years ago

That would be great, thanks!