phenoscape / rphenoscape

R package to make phenotypic traits from the Phenoscape Knowledgebase available from within R.
https://rphenoscape.phenoscape.org/
Other
5 stars 5 forks source link

Removes KB API limit work around #227

Closed johnbradley closed 3 years ago

johnbradley commented 3 years ago

Previously the KB API had no mechanism to limit some queries so instead we used really large magic numbers. The change here is to use 0 for limit that is now supported by the KB API.

Fixes #183

johnbradley commented 3 years ago

The phenotype limit was already being tested:

https://github.com/phenoscape/rphenoscape/blob/b668eb99c7fd29dc24a2ee6dd4c7f19a48926aca/tests/testthat/test-phenotypes.R#L7