search

phenoscape / rphenoscape

R package to make phenotypic traits from the Phenoscape Knowledgebase available from within R.
https://rphenoscape.phenoscape.org/
Other
5 stars 5 forks source link

Resolve duplicated test #232

Closed johnbradley closed 3 years ago

johnbradley commented 3 years ago

We have two copies of the Test getting study information test:

https://github.com/phenoscape/rphenoscape/blob/3759ab34b818ebe40adb349a7b5a729ce5bd7408/tests/testthat/test-study.R#L3-L8

https://github.com/phenoscape/rphenoscape/blob/3759ab34b818ebe40adb349a7b5a729ce5bd7408/tests/testthat/test-pk.R#L193-L198

The main change is the newer version of this test in test-study.R uses get_studies() instead of pk_get_study_list().

The test-study.R version of this tests contains everything (and more) from the test-pk version with the exception of: https://github.com/phenoscape/rphenoscape/blob/3759ab34b818ebe40adb349a7b5a729ce5bd7408/tests/testthat/test-pk.R#L252-L257

johnbradley commented 3 years ago

Fixed by #233