search

phenoscape / rphenoscape

R package to make phenotypic traits from the Phenoscape Knowledgebase available from within R.
https://rphenoscape.phenoscape.org/
Other
5 stars 5 forks source link

Upgrade main (master) branch to v0.3.0 pre-release #261

Closed hlapp closed 2 years ago

hlapp commented 2 years ago

Not ready quite yet, but almost there.

hlapp commented 2 years ago

@johnbradley do you know about the conflict in .github/workflows/check-standard.yaml or is this bogus?

johnbradley commented 2 years ago

@johnbradley do you know about the conflict in .github/workflows/check-standard.yaml or is this bogus?

The .github/workflows/*.yaml files were removed in the baseline-v0.3.0 since we are switching to use CircleCI for a more reliable network for tests. The .github/workflows/check-standard.yaml file should be removed. I guess we made a fix in master to this file that didn't make it to baseline-v0.3.0. Let me know if you would like me to resolve this.

hlapp commented 2 years ago

The .github/workflows/*.yaml files were removed in the baseline-v0.3.0 since we are switching to use CircleCI for a more reliable network for tests. The .github/workflows/check-standard.yaml file should be removed.

Ah yes, that makes sense. I'll work this out. (Famous last words 🤣)

I assigned you as reviewer, but obviously this isn't about reviewing the actual code change (we did that in numerous pieces already), but asking whether anything's still missing before merging or whether indeed this is the moment. (My plan was to regenerate the website after the merge, not prior to it. I also now incremented the version.)

hlapp commented 2 years ago

I think I got the merge conflict worked out, I'm just repeating the removal of both Github Action files to reflect that baseline-v0.3.0 status.