PC-226: Make Advanced filters UI more intuitive

phenotips / phenomecentral.org

The phenomecentral.org website

GNU Affero General Public License v3.0

2 stars 8 forks source link

PC-226: Make Advanced filters UI more intuitive #101

Closed veronikaslc closed 6 years ago

veronikaslc commented 6 years ago

Advanced filters are updated, except translastion changes, which are minor. @sdumitriu should they also be in the fix? If yes - where is the right place to put this ApplicationResources.properties file?

sashaandjic commented 6 years ago

lookup is missing for "By owner" and "By collaborator" filters
also DOB, Phenotypes, Clinical and Final diagnosis filters are missing

(blue screenshot is taken from phenotips playgorund, orange from local phenomecentral instance) screen shot 2018-01-22 at 1 15 24 pm

sashaandjic commented 6 years ago

Export dialog is also missing above mentioned filter fields screen shot 2018-01-22 at 1 41 22 pm

veronikaslc commented 6 years ago

@sashaandjic codereview comments addressed

sashaandjic commented 6 years ago

suggestions for owner and collaborator fields are still not present pc-226

allasm commented 6 years ago

I'm not even sure how to review this, a LOT of new velocity code (which as far as I understand is back-ported from Phenotips 1.4). It is very hard to tell if all of the code is ok and/or plugged in correctly. Don't see anything wrong so I would approve it given @sashaandjic has tested it