search

phenotips / remote-matching

Patient matching across applications
2 stars 2 forks source link

RM-127: MME parser does not properly handle extra leading or trailing spaces in term IDs #92

Closed allasm closed 5 years ago

allasm commented 5 years ago

(it is best to view changes ignoring whitespace https://github.com/phenotips/remote-matching/pull/92/files?w=1)

sashaandjic commented 5 years ago

i see 2 vms running for this PR: RM-127-bad-server and master_RM-127_master. The later one has way more matches than the first one (bad-server) and I'm assuming this is expected, however I'm not sure how to best test this PR. @allasm please advise.

allasm commented 5 years ago

There is a very detailed explanation on Slack