search

phenotypic / homebridge-web-thermostat

Homebridge plugin for a web-based thermostat
MIT License
18 stars 15 forks source link

setTargetHeatingCoolingState() sets current instead of target heating state #12

Closed Eddy-the-Git closed 3 years ago

Eddy-the-Git commented 4 years ago

Line 161:

this.service.getCharacteristic(Characteristic.CurrentHeatingCoolingState).updateValue(value)

should update the Characteristic.TargetHeatingCoolingState value like it advertises in line 160:

this.log('Set targetHeatingCoolingState to: %s', value)

phenotypic commented 3 years ago

Good suggestion, but I feel this will be better solved with a change to a _getStatus function call instead after any target API calls. See your other issue #13 for more details.