search

phergie / phergie-irc-bot-react

IRC bot built on React
BSD 2-Clause "Simplified" License
81 stars 26 forks source link

Add PluginContainerInterface for plugins that have nested plugins #18

Closed Renegade334 closed 9 years ago

Renegade334 commented 9 years ago

Allows the bot to call plugin processors on nested plugins that are not a part of $config['plugins'].

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.03%) to 97.36% when pulling d9406f48c2284c990c606d4da89dd7a0a71aed68 on Renegade334:devel-plugin-container into aef6a00739c221bc2442405cd6454fa6bb264b54 on phergie:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.03%) to 97.36% when pulling d9406f48c2284c990c606d4da89dd7a0a71aed68 on Renegade334:devel-plugin-container into aef6a00739c221bc2442405cd6454fa6bb264b54 on phergie:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.05%) to 97.38% when pulling 605d1e285658369e9d5849da888f02d0b62a0c12 on Renegade334:devel-plugin-container into aef6a00739c221bc2442405cd6454fa6bb264b54 on phergie:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.05%) to 97.38% when pulling 22eb4f9ba2369e94466759905e381a1c6569a42a on Renegade334:devel-plugin-container into aef6a00739c221bc2442405cd6454fa6bb264b54 on phergie:master.

elazar commented 9 years ago

We'll go ahead and merge this as-is for now. I've filed a feature request for adding support for mocking classes and multiple interfaces simultaneously in Phake. If that ends up being developed, we can refactor the TestPluginContainer class added by this PR into a mock object at that point.