Closed Renegade334 closed 9 years ago
Very nice work. We'll need to add this to the wiki and update any plugins that currently maintain their own storage of event queues, such as FeedTicker.
Hm, one minor issue that I missed and Scrutinizer picked up: setEventQueueFactory()
uses $queueFactory
in the method declaration and $factory
in the docblock.
public function setEventQueueFactory(EventQueueFactoryInterface $queueFactory)
* @param \Phergie\Irc\Bot\React\EventQueueFactoryInterface $factory
:-/
Can you ret-con it yourself?
Yup, I'll get it. Thanks.
Edit: Done. c4e857f92d045cd6c879744f1291518714a5ca52
Plugins can now use the event queue factory to resolve connections to event queue instances, for processing asynchronous events without having to store event queue instances or play object ping-pong.