Bugfix: When setting the logger of the bot, we have to change the log…

[iwalkalone69]

…ger of irc connection to take effect.

[elazar]

Can you update this test accordingly, please?

[iwalkalone69]

Test updated.

[elazar]

Note the comment above this test indicating that it's intended to be a unit test. Your change makes it rely on the behavior of the client dependency so that it becomes an integration test.

To correct this:

$client = $this->getMockClient();
$this->bot->setClient($client);
$this->bot->setLogger($logger);
Phake::verify($client)->setLogger($logger);

This makes it a unit test again because it no longer relies on the behavior of the setLogger() and getLogger() methods of the client dependency, only verifies that setLogger() is called with the correct parameter.

[iwalkalone69]

Updated test.

[elazar]

@iwalkalone69 Sorry, I did not mean to imply that my example constituted the whole test. You've removed the assignment for $logger, which is still needed.

[enebe-nb]

Probably is this what elazar wants:

    public function testSetLogger()
    {
        $client = $this->getMockClient();
        $logger = $this->getMockLogger();
        $this->bot->setClient($client);
        $this->bot->setLogger($logger);
        $this->assertSame($logger, $this->bot->getLogger());
        Phake::verify($client)->setLogger($logger);
    }

[elazar]

@enebe-nb Not sure @iwalkalone69 is still monitoring this issue. If you'd care to re-submit this PR with appropriate fixes, I'll be happy to merge it. :)

[iwalkalone69]

Sorry. I had to leave this for a while because I had to focus on another thing. I will take care now.

[elazar]

@iwalkalone69 No worries, looks like @enebe-nb beat you to it. ;)

[iwalkalone69]

That's right! Thanks @elazar and @enebe-nb !