Fixed bug and refactored code

phergie / phergie-irc-bot-react

IRC bot built on React

BSD 2-Clause "Simplified" License

81 stars 26 forks source link

Fixed bug and refactored code #44

Closed aurimasniekis closed 5 years ago

aurimasniekis commented 8 years ago

Fixed that parser is impossible to change via config because it's injected even before its get parsed from $config. Also removed $bot as now the PHP support is >5.5 so you can use $this inside anonymous functions

elazar commented 8 years ago

@gcds Any chance you could add a test that confirms the bug fix?

aurimasniekis commented 8 years ago

maybe later

matthewtrask commented 7 years ago

@aurimasniekis are you still adding tests?

elazar commented 6 years ago

@svpernova09 @matthewtrask Perhaps we should just go ahead and merge this? Not sure what bug it allegedly fixes, but it at least makes the code a bit more clean / modern.