search

phergie / phergie-irc-bot-react

IRC bot built on React
BSD 2-Clause "Simplified" License
81 stars 26 forks source link

Support evenement 2.0 and 3.0 #51

Closed WyriHaximus closed 6 years ago

WyriHaximus commented 6 years ago

Evenement 3.0 has 99.9% the same API as 2.0 and provides a contains a nice performance improvement. I didn't see any cases where it would cause issues with Phergie so it should be good to go 🎉

WyriHaximus commented 6 years ago

ping @elazar @svpernova09 is there anything blocking this from getting merged (and preferably released)?

elazar commented 6 years ago

@WyriHaximus Is there anything we can do to fix the build failures?

WyriHaximus commented 6 years ago

@elazar I can look into those, but they seem unrelated to this PR so I'll be filing a new one

WyriHaximus commented 6 years ago

@elazar just filed #52 which should fix these errors

WyriHaximus commented 6 years ago

Rebased and squashed

elazar commented 6 years ago

👍

svpernova09 commented 6 years ago

Thanks!

WyriHaximus commented 6 years ago

Awesome 🎉 . Any chance for a tag soon?