EventQueue does not guarantee timestamp ordering because timestamps may collide.

phergie / phergie-irc-bot-react

IRC bot built on React

BSD 2-Clause "Simplified" License

81 stars 26 forks source link

Closed PSchwisow closed 9 years ago

PSchwisow commented 9 years ago

If several events are queued together, they may have the same timestamp, so order of execution is non-deterministic.

As recommended by elazar:

Add a property to the event queue that keeps the last timestamp value that was used.
Check the generated timestamp value in getPriority() against that property's value.
If they match, increment the generated value by 1.
And then store the generated value in the property.
That should guarantee that no duplicates occur, I think.

PSchwisow commented 9 years ago

Looks like I can't assign to myself, but I plan on doing a PR for this when I have a chance.

PSchwisow commented 9 years ago

elazar commented 9 years ago

Merged. Thanks!