search

phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Use react/dns for server IP lookups #14

Closed WyriHaximus closed 10 years ago

WyriHaximus commented 10 years ago

Instead of using PHP's internal DNS loopup that blocks. This PR brings non-blocking DNS lookups using react/dns to Phergie.

elazar commented 10 years ago

Seeing failures in 5.3.3 and 5.3.x: https://travis-ci.org/phergie/phergie-irc-client-react/builds/26347395

WyriHaximus commented 10 years ago

Heh! Ow doh I see it, getContact is protected and in 5.3 using $that = $this it has to be public.

elazar commented 10 years ago

No worries, I fixed it. :) 7315abda03222c70226a5668f5ab3b702706c098

WyriHaximus commented 10 years ago

:+1: