search

phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
57 stars 26 forks source link

[WIP] 5.4 requirement, latest React Stream interface #21

Closed cboden closed 10 years ago

cboden commented 10 years ago

refs #15, refs #20

elazar commented 10 years ago

Looks like these lines need to be removed for the build to pass.

elazar commented 10 years ago

Wow, you even went back and fixed up instances where I'd marked off code to be amended when we ended 5.3 support. Dude, you rock! :) The build passes, so unless you have something else you want/need to do, I'd say this is good to be merged.

elazar commented 10 years ago

@cboden Any chance react/stream 0.4.2 will be tagged soon so we can adjust composer.json? Or can you just set it to 0.4.* in this branch?

cboden commented 10 years ago

I'll tag and update this PR when I get home from work tonight.

cboden commented 10 years ago

:+1:

elazar commented 10 years ago

Many thanks for your contributions, good sir. :)