search

phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Create a new release #23

Closed hason closed 9 years ago

elazar commented 9 years ago

Working on it. ;) Was mostly waiting on a resolution for #15. Have one issue to fix with the phergie-irc-bot-react build, then I'll look at pushing a release out.

rawtaz commented 9 years ago

@elazar Will that next release be 1.0.1?

elazar commented 9 years ago

I realize it's odd, but I think we may actually have to make the release 2.0.0. The reasoning is that we're having to bump the minimum PHP version requirement from 5.3 to 5.4. There are two major reasons for this:

  1. 5.3 is now at end of life with no further releases planned.
  2. In order to address some issues with SSL, we've had to upgrade the versions of underlying React library dependencies, which require 5.4.

Aside from the version bump, there shouldn't be any BC breaks. I'm open to discussion on the next version being 1.1.0 instead, but for the moment, those are my thoughts on the matter.

grahamc commented 9 years ago

I would consider dropping an entire platform a breaking change, 2.0.0 seems right. Any API changes you've been meaning to make? :)

rawtaz commented 9 years ago

1.1 would work but 2.0 probably makes more sense, so why not.

elazar commented 9 years ago

I think the only remaining blocker at this point is this test failure under HHVM 3.3.0. If anyone wants to help look into that, it would be appreciated.

WyriHaximus commented 9 years ago

+1 for going with 2.0 as you're making a breaking change

elazar commented 9 years ago

Found a work-around for the issue causing the test failure. Hoping to push new releases within the week.