search

phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Capture 'end' event from read stream. #28

Closed jkazimir closed 9 years ago

jkazimir commented 9 years ago

Currently the write stream is the only one being listened to for an 'end' event. This PR adds listening for the 'end' event from the read stream as well.

Cheers!

elazar commented 9 years ago

There appears to be a syntax error in this commit, at least insofar as the tests are concerned. Please address this and re-run the test suite locally to confirm that the issue is resolved before pushing an additional commit. Thanks in advance for your contribution.

jkazimir commented 9 years ago

Yep, already noticed, and corrected.. "It's one line of code, what could possibly go wrong?" -- famous last words...

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.05% when pulling c6d2ece8d472d68274c4e1de0d1df69033cac229 on jkazimir:patch-1 into 719c118881de23007945161c4b95149cd3bcbcf5 on phergie:master.

elazar commented 9 years ago

That's why we have tests. :) Also, it seems like at least one of the tests should be updated to reflect this addition. My guess would be ClientTest->testEndCallback().

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.05% when pulling c189cf31a51d4a9f65eb527dd8d3e0324c12ec5f on jkazimir:patch-1 into 719c118881de23007945161c4b95149cd3bcbcf5 on phergie:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 99.05% when pulling c189cf31a51d4a9f65eb527dd8d3e0324c12ec5f on jkazimir:patch-1 into 719c118881de23007945161c4b95149cd3bcbcf5 on phergie:master.

elazar commented 9 years ago

Thanks!