Closed Renegade334 closed 8 years ago
@svpernova09 Note that implementing this change will effectively deprecate the Pong plugin for the bot.
Additionally, since there's no way to disable this new behavior and any existing installations that include the Pong plugin would at that point be sending two PONG
events per one PING
event at that point. I'm uncertain how servers will respond to that behavior; it may have no effect at all. Regardless, it's something to be aware of and something that should probably be included in release notes.
@elazar Thanks, I was going to hold off tagging this anyway. So I'll hold off until I can test if there are any ill effects of double pongs.
ref: #40
There are certain functions of a client that are essential to the client-server relationship, such as responding to server
PING
events.This patch would provide a means for the client to provide such functionality as core. The method
processInput()
processes the parser output and performs whatever functionality is deemed fit. At the moment, two functions are performed, although more could be added:Connection::setNickname()
when the server confirms that the client's nick has changedPONG
command when the client is pinged by the serverVery much up for discussion.