phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Internal processing #42

Closed Renegade334 closed 8 years ago

Renegade334 commented 9 years ago

ref: #40

There are certain functions of a client that are essential to the client-server relationship, such as responding to server PING events.

This patch would provide a means for the client to provide such functionality as core. The method processInput() processes the parser output and performs whatever functionality is deemed fit. At the moment, two functions are performed, although more could be added:

Very much up for discussion.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.34%) to 97.48% when pulling 7b17311a4c806b4821b1bce73c1e592ac109ed85 on Renegade334:devel-internal-processing into 63d736cbfadaf0dc2948f05cc808cd12dcdbf42a on phergie:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.03%) to 98.86% when pulling 9271a2d9b8a17eb6092a49866fbfc05cffdf9685 on Renegade334:devel-internal-processing into 63d736cbfadaf0dc2948f05cc808cd12dcdbf42a on phergie:master.

elazar commented 8 years ago

@svpernova09 Note that implementing this change will effectively deprecate the Pong plugin for the bot.

Additionally, since there's no way to disable this new behavior and any existing installations that include the Pong plugin would at that point be sending two PONG events per one PING event at that point. I'm uncertain how servers will respond to that behavior; it may have no effect at all. Regardless, it's something to be aware of and something that should probably be included in release notes.

svpernova09 commented 8 years ago

@elazar Thanks, I was going to hold off tagging this anyway. So I'll hold off until I can test if there are any ill effects of double pongs.