search

phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Only resolve server hostname when it isn't an IP address #53

Closed WyriHaximus closed 7 years ago

WyriHaximus commented 8 years ago

Don't merge yet

Currently the client doesn't check whenever the inputted hostname is an IP address or FQDN. This patch will resolve that issue.

elazar commented 7 years ago

@WyriHaximus What should be done with this PR?

WyriHaximus commented 7 years ago

@elazar no clue :fearful: . But it looks good and valid. What do you think?

elazar commented 7 years ago

@WyriHaximus So long as tests cover cases for valid and invalid hostnames and IP addresses, works for me. 👍

svpernova09 commented 7 years ago

Tested this and didn't see anything break.