search

phergie / phergie-irc-client-react

IRC client library built on React
BSD 3-Clause "New" or "Revised" License
56 stars 26 forks source link

Test with pecl event #56

Closed sitedyno closed 7 years ago

sitedyno commented 7 years ago

Using the PECL event extension results in a fatal error. There is a fix for this here: https://github.com/reactphp/event-loop/releases/tag/v0.4.2 I'll be happy to add the commit to update react/event-loop, but I just wanted you folks to see why (in the tests) :)

For more info see this pull request: https://github.com/reactphp/event-loop/pull/45

elazar commented 7 years ago

👍 Thanks @sitedyno!

sitedyno commented 7 years ago

I'm not sure this should be merged. Once I get past the fatal error I'm unable to get Phergie to connect via SSL. Remove PECL event and Phergie connects via SSL just fine. There is no error, just the blinking cursor of "I ain't tellin you nothin". No fault of Phergie's that I can tell, seems to be some integration issue w/ React & PECL event.

:8ball:

I will close this for now. If you guys want to merge feel free.