Updated to the latest ReactPHP versions

phergie / phergie-irc-client-react

IRC client library built on React

BSD 3-Clause "New" or "Revised" License

56 stars 26 forks source link

Updated to the latest ReactPHP versions #65

Closed WyriHaximus closed 6 years ago

WyriHaximus commented 6 years ago

[X] Update Packages in composer.json
[X] Update Client
[x] Update ReadStream
[x] Update WriteStream
[x] Test in project
[x] Try to support older versions as well

Note that this is a work in progress, I'll update the tile once it's ready for review.

matthewtrask commented 6 years ago

This is awesome!

WyriHaximus commented 6 years ago

@matthewtrask thanks! There has been some great improvements since the versions used in this package. It's time to update :tada:

WyriHaximus commented 6 years ago

Essentially this PR Is done @elazar @matthewtrask @svpernova09 but @elazar mentioned some bigger changes on IRC. Do we want that in this PR as well, or should I create a followup with those changes?

elazar commented 6 years ago

I'd say this is fine as-is. Bigger changes can wait for a followup PR.

WyriHaximus commented 6 years ago

Sounds good to me, will try and sort backwards compatible tomorrow 👍

WyriHaximus commented 6 years ago

Updated the PR so it supports all the currently supported react/stream versions

WyriHaximus commented 6 years ago

:tada: