Alias timer interface for event-loop 0.4 and 0.5 compatibility

phergie / phergie-irc-client-react

IRC client library built on React

BSD 3-Clause "New" or "Revised" License

56 stars 26 forks source link

Alias timer interface for event-loop 0.4 and 0.5 compatibility #68

Closed WyriHaximus closed 6 years ago

WyriHaximus commented 6 years ago

In react/event-loop 0.5 we moved the TimerInterface in https://github.com/reactphp/event-loop/pull/138. This PR adds a compatibility file to make sure this package keeps working with event-loop 0.4 and 0.5.

WyriHaximus commented 6 years ago

@elazar as discussed updated this PR to drop react/event-loop 0.4 support

elazar commented 6 years ago

Looks good to me. We'll need to document that Client->isTimerActive() has been removed when these changes are released. Since this is technically a major API change, I'd assume it would require a major version bump.

WyriHaximus commented 6 years ago

:tada: