search

phetsims / a11y-research

a repository to track PhETs research into accessibility, or "a11y" for short
MIT License
3 stars 0 forks source link

A11y View is brittle when build #111

Closed zepumph closed 6 years ago

zepumph commented 6 years ago

Right now there are just hard-coded domains that will trigger the sim filename to change in the a11y view, like 

  // support multiple dev sites
  var onDevSite = [ 'bayes.colorado.edu', 'phet-dev.colorado.edu', 'www.colorado.edu' ].indexOf( window.location.hostname ) >= 0;

  var brandSuffix = onDevSite ? '_phet' : '';   // add brand name for dev deploys

This currently doesn't work for localbuild, or for production build (if we are sending it there). I don't want to overhaul this whole thing right now (nor does @jessegreenberg), but at least we should add 'localhost' to that list.

zepumph commented 6 years ago

Duplicate of https://github.com/phetsims/chipper/issues/667, closing