phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html
GNU General Public License v3.0
4 stars 7 forks source link

shorten the pH probe #160

Closed pixelzoom closed 3 years ago

pixelzoom commented 5 years ago

... as describe in https://github.com/phetsims/acid-base-solutions/issues/158#issuecomment-482162725.

The pH probe's initial location is close to the top of the screen. On iPhone this can cause the iPhone menu to be dragged down instead of the pH meter. So we're going to shorten the probe, move the pH meter's initial location down, and adjust the drag bounds accordingly.

pixelzoom commented 5 years ago

The probe length has been shortened from 50 to 40, and drag range adjusted accordingly. (I tried 35 and it looked too short.) See screenshots below comparing initial location before and after this change, shown with ?dev so you can see the layout bounds.

@KatieWoe @arouinfar please review in master and verify that this addresses the usability concern.

Before (published version 1.2.19)

screenshot_1288

After (master)

screenshot_1289
arouinfar commented 5 years ago

@pixelzoom the screenshot with shorter length looks good to me. Since the original motivation for this change related to a pesky iPhone menu, and I don't have an iPhone, I'll defer to @KatieWoe

KatieWoe commented 5 years ago

Still occurs but much easier to get around now

pixelzoom commented 5 years ago

I could make the probe even shorter, but I think that starts to compromise things. @kathy-phet @KatieWoe let me know what you think.

And again... It would be really nice to have some standards for margins, since this is a general problem.

KatieWoe commented 5 years ago

I don't think it's necessary. Like I said, it is much better, and being shorter could cause more problems. We would probably have to move too far from the edge of the screen for this to stop happening all together. This distance seems to prevent major disruption/feels better to me, so my vote is stop here. @kathy-phet to make final decision though.

pixelzoom commented 5 years ago

@kathy-phet reminder that this is awaiting your review.

pixelzoom commented 4 years ago

I'm going to go with @KatieWoe's opinion (which I agree with), and mark this as "fixed-awaiting-deploy".

liammulh commented 3 years ago

The pH probe is shorter. Reassigning @pixelzoom.

pixelzoom commented 3 years ago

Thanks @liam-mulhall. Closing.