use AquaRadioButtonGroup

phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html

GNU General Public License v3.0

4 stars 7 forks source link

use AquaRadioButtonGroup #161

Closed pixelzoom closed 1 year ago

pixelzoom commented 4 years ago

From phetsims/sun#555, convert this sim to use AquaRadioButtonGroup for phet-io.

Use in place of AquaRadioButton in these places:

[x] SolutionsControl, this should be straightforward

[ ] ViewsControl, this is problematic. AquaRadioButtonGroup does not support interleaving of the "Solvent" checkbox.

pixelzoom commented 4 years ago

Note that in #165, ViewsControl became ViewsPanel, and now looks like this:

pixelzoom commented 4 years ago

ViewsControl is blocked by phetsims/sun#583.

pixelzoom commented 4 years ago

From https://github.com/phetsims/sun/issues/583#issuecomment-610571992:

More notes from 3/26/20 dev meeting... It was suggested that the problem with BEERS_LAW_LAB/ViewsControl might be resolved by redesigning it. We should certainly consider that. But my opinion is that this is a perfectly valid design, there's nothing wrong with it, and switching to an inferior design to avoid the problem is not a "solution".

pixelzoom commented 1 year ago

I'm punting on changes to ViewsPanel. If https://github.com/phetsims/sun/issues/555 is ever addressed, we can revisit. But I think it's very low priority.

In https://github.com/phetsims/acid-base-solutions/issues/186, I've described my solution for the PhET-iO aspects.

Closing.