Reset All button moves around when switching screens

phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 7 forks source link

Closed pixelzoom closed 3 years ago

pixelzoom commented 4 years ago

While creating https://github.com/phetsims/acid-base-solutions/issues/165, I noticed that the Reset All button does not conform to PhET standards in this sim.

[x] Its location changes when you switch between screens.
[x] Its size is also a bit larger than the standard, because the sim uses non-default layoutBounds.
[x] Instead of being created by the ScreenView, it's created in ABSControls. This will cause problems with the tandem hierarchy when this sim is PhET-iO instrumented.

pixelzoom commented 4 years ago

Done in the above commit. Ready for testing next time this sim is deployed.

liammulh commented 3 years ago

The Reset All button no longer "moves" when switching screens. Reassigning @pixelzoom.

pixelzoom commented 3 years ago

Thanks @liam-mulhall. Closing.