CT Assertion failed when allowLinksFalse

[KatieWoe]

acid-base-solutions : fuzz : unbuilt : query-parameters : allowLinksFalse
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/acid-base-solutions/acid-base-solutions_en.html?continuousTest=%7B%22test%22%3A%5B%22acid-base-solutions%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22query-parameters%22%2C%22allowLinksFalse%22%5D%2C%22snapshotName%22%3A%22snapshot-1658747812005%22%2C%22timestamp%22%3A1658754221182%7D&brand=phet&fuzz&memoryLimit=1000&ea&allowLinks=false
Query: brand=phet&fuzz&memoryLimit=1000&ea&allowLinks=false
Uncaught Error: Assertion failed
Error: Assertion failed
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/assert/js/assert.js:28:13)
at assert (RichText.ts:1362:14)
at setLinks (RichText.ts:1371:50)
at (Node.ts:6342:10)
at arrayEach (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/sherpa/lib/lodash-4.17.4.js:537:11)
at Function.forEach (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/sherpa/lib/lodash-4.17.4.js:9359:14)
at each (Node.ts:6325:6)
at mutate (RichText.ts:1462:17)
at mutate (RichText.ts:375:9)
at (UpdateNodes.ts:118:21)
id: Bayes Puppeteer
Snapshot from 7/25/2022, 5:16:52 AM

----------------------------------

acid-base-solutions : fuzz : unbuilt : query-parameters : allowLinksFalse
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/acid-base-solutions/acid-base-solutions_en.html?continuousTest=%7B%22test%22%3A%5B%22acid-base-solutions%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22query-parameters%22%2C%22allowLinksFalse%22%5D%2C%22snapshotName%22%3A%22snapshot-1658747812005%22%2C%22timestamp%22%3A1658760424386%7D&brand=phet&fuzz&memoryLimit=1000&ea&allowLinks=false
Query: brand=phet&fuzz&memoryLimit=1000&ea&allowLinks=false
Uncaught Error: Assertion failed
Error: Assertion failed
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/assert/js/assert.js:28:13)
at assert (RichText.ts:1362:14)
at setLinks (RichText.ts:1371:50)
at (Node.ts:6342:10)
at arrayEach (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/sherpa/lib/lodash-4.17.4.js:537:11)
at Function.forEach (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1658747812005/sherpa/lib/lodash-4.17.4.js:9359:14)
at each (Node.ts:6325:6)
at mutate (RichText.ts:1462:17)
at mutate (RichText.ts:375:9)
at (UpdateNodes.ts:118:21)
id: Bayes Puppeteer
Snapshot from 7/25/2022, 5:16:52 AM

[samreid]

I'm investigating this and have no idea why it affects acid-base-solutions but not other sims. Also, I'm seeing it on CT but cannot reproduce it locally yet.

[samreid]

I believe this broke in https://github.com/phetsims/joist/commit/6355ee5fb3c82933019f77c99e77f15c16190418

[samreid]

It is only affecting Acid Base Solutions because it is the only sim tested with this query string:

https://github.com/phetsims/perennial/blob/6d176f12e4dc5dac7fde027dd25beff24ac9b3b8/js/listContinuousTests.js#L370-L392

[samreid]

Fixed, @marlitas can you please review?

[marlitas]

Changes look good. Thanks for addressing this @samreid. Sending back for any follow up or closing that may need to happen.

[samreid]

Thanks, it seems good to close and we can reopen if it recurs on CT.