PhET-iO instrumentation

[pixelzoom]

Good progress on this in the many commits above.

I've created separate issues for some bigger things. Here's an list of smaller things that still need to be addressed.

• [x] "Particles" view does not have counts of the particles shown.
• [x] Bars in the "Graph" view do not indicate which particle type they are associtated with.
• [x] Bars in the "Graph" view show their value as text in scientific notation, but you cannot get the value in standard numeric form.
• [x] Bars in the "Graph" view that are not visible (specifically graphNode.bars.barNode3) will have stale state.
• [x] Some views are optimized to update only when they're visible, so will not be in sync with the model when invisible. Is that a problem for PhET-iO? This includes:
  • PHPaperNode color
  • MagnifyingGlassNode particles
  • ConcentrationGraphNode bars and values See https://github.com/phetsims/acid-base-solutions/issues/191#issuecomment-1658942540

EDIT: These were moved to https://github.com/phetsims/acid-base-solutions/issues/193:

• [ ] Water has concentration of 0, which is outside of ABSConstants.CONCENTRATION_RANGE
• [ ] Water has strength of 0, which is outside of ABSConstants.WEAK_STRENGTH_RANGE.
• [ ] All non-Water solutions in the Intro screen have concentration 1E-2. Should that be editable via PhET-iO? Per solution or globally?
• [ ] Strong solutions have strength 101, which is outside of range ABSConstants.WEAK_STRENGTH_RANGE. Maybe strengthPropery should be renamed weakStrenghtProperty, since it's only relevant for weak solutions.

[pixelzoom]

This is back on hold. Unassigning.

[pixelzoom]

This is back on PhET's radar for a client. @kathy-phet would like to know what effort is needed to complete the initial instrumentation. Self assigning...

[pixelzoom]

As of 7/27/23, the status is:

• Remaining development work (that has been identified) is summarized in checklist https://github.com/phetsims/acid-base-solutions/issues/178#issuecomment-1360622707, and in 6 standalone GitHub issues (see https://github.com/phetsims/acid-base-solutions/issues?q=is%3Aissue+is%3Aopen+label%3Adev%3Aphet-io). Most of these are significant changes.
• A few parts of the instrumentation were a bit non-standard, due to the nature of the UI design. Those parts are ready for review at any time, in these 3 issue: https://github.com/phetsims/acid-base-solutions/issues?q=is%3Aissue+is%3Aopen+label%3Adesign%3Aphet-io
• This sim has had no formal PhET-iO design process. I created this “PhET-iO Design” issue: https://github.com/phetsims/acid-base-solutions/issues/190

[pixelzoom]

The Studio tree is now in good shape, ready for review.

Testing with the State wrapper also looks good, with one expection: https://github.com/phetsims/acid-base-solutions/issues/195

[pixelzoom]

Initial instrumentation is done. Additional tasks will be identified in #190 PhET-iO design, and tracked in new GitHub issues.

Closing.