search

phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html
GNU General Public License v3.0
4 stars 7 forks source link

"Molecules" is incorrect terminology #184

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Similiar to https://github.com/phetsims/ph-scale/issues/258 that was identified by @Nancy-Salpepi ...

In Acid-Base solutions, both screeens have a radio button labeled "Molecules" that shows a qualitative representation of the ratio of particles in the solution. For example:

screenshot_2078

As with https://github.com/phetsims/ph-scale/issues/258, the problem is that we are showing a combination of molecules (neutral) and icons (charged) particles, not just "Molecules".

Thankfully this is the only place that "Molecules" appears in the UI. So we should probably change the radio button label to "Particles". Then change the code, tandems, etc. as we did in https://github.com/phetsims/ph-scale/issues/258. No migration rules are required because a PhET-iO version of this sim has never been published. (I'm in the middle of instrumenting it.)

@arouinfar OK to proceed?

pixelzoom commented 1 year ago

Slack DM:

@pixelzoom OK to make this change? https://github.com/phetsims/acid-base-solutions/issues/184

@arouinfar Yep!

pixelzoom commented 1 year ago

Done, closing.