Revisit Studio tree structure for "Particles" view

phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html

GNU General Public License v3.0

4 stars 7 forks source link

Revisit Studio tree structure for "Particles" view #204

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

This structure seems a little reversed:

Since the radio button choice is "Particles", it might make more sense to have:

- particlesNode
  countAProperty
  countBHProperty
  countBProperty
  countH3OProperty
  countHAProperty
  countMOHProperty
  countMProperty
  countOHProperty
  +visibleProperty

... where magnifyingGlassNode is not instrumented, since it serves no purpose to hide it separately.

To be discussed with @arouinfar ...

pixelzoom commented 1 year ago

Somewhat related... In the above commits, I got rid of MagnifyingGlass.ts and ConcentrationGraph.ts. They didn't add anything, and were not instrumented.

pixelzoom commented 1 year ago

Done in the above commits, as shown below. Much cleaner. Closing.