search

phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html
GNU General Public License v3.0
4 stars 7 forks source link

Instrument pH paper colors, so that they can be customized. #215

Closed pixelzoom closed 1 year ago

pixelzoom commented 1 year ago

Based on https://github.com/phetsims/acid-base-solutions/issues/173, it's likely that a PhET-iO client may want to customize the pH paper colors to match a different Universal Indicator standard. So we will instrument those colors.

pixelzoom commented 1 year ago

Ready for review by @arouinfar. Close if OK.

Note that colors currently live under acidBaseSolutions.global.view.colors. That may change, depending on the resolution to https://github.com/phetsims/tandem/issues/303.

arouinfar commented 1 year ago

Thanks @pixelzoom, looks good on main.

arouinfar commented 1 year ago

Tagging #190 so this issue shows up there.