phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html
GNU General Public License v3.0
4 stars 7 forks source link

Instrument data labels in `graphNode` #221

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

For #190

The tree structure of graphNode currently looks like this:

image

Clients can hide the grid lines and tick marks, but they cannot hide the data labels that display the quantitative values.

image

Hiding the data labels would allow for a more qualitative experience. I don't see any need to hide the values individually, a global control like gridLines would work well here.

@pixelzoom here's a proposed tree structure. If there's a term you prefer more than dataLabels, go for it.

- graphNode
    + bars
    - dataLabels
        visibleProperty
    + gridLines 
    + tickMarks
    + visibleProperty
pixelzoom commented 1 year ago

Slack#DM with @arouinfar:

@pixelzoom: What I had in mind was adding graphNode.valuesVisibleProperty. Does that sound acceptable?

@arouinfar Love it

pixelzoom commented 1 year ago

I added graphNode.valuesVisibleProperty.

Ready for review by @arouinfar. Close if OK.

arouinfar commented 1 year ago

Thanks @pixelzoom, this looks great on main. I've also made a note to document this in the examples, closing.