phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html
GNU General Public License v3.0
4 stars 7 forks source link

ph paper color resets to default if not in solution #234

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air M1 chip

Operating System 13.5.1

Browser Safari 16.6

Problem description For https://github.com/phetsims/qa/issues/975, in Studio or State: On either screen, if I move a piece of pH paper out of the solution, the color resets to the default in the launched sim.

Steps to reproduce

  1. In the state wrapper, set state rate = 0
  2. Select the pH paper radio button
  3. Dip a piece of pH paper fully into solution and then pull it out
  4. Press Set State Now

Visuals

Screenshot 2023-09-07 at 7 14 14 PM
Nancy-Salpepi commented 1 year ago

I also see a difference when I fully dip the pH paper, leave it in the beaker, and then set state.

Screenshot 2023-09-08 at 8 22 20 AM
pixelzoom commented 1 year ago

Great catch @Nancy-Salpepi. There was a Property that was not instrumented, so not appearing in the state. I've corrected that in the commits below.

@arouinfar FYI the Property is shown below. It is readonly because it's controlled by the sim, and it is not featured. Let me know if you want any changes here.

Assigning to @Nancy-Salpepi and @arouinfar for review. Last one to review please close this issue if everything is OK.

screenshot_2766
pixelzoom commented 1 year ago

FYI... I took another look through the code, and confirmed that all non-derived Properties are instrumented.

Nancy-Salpepi commented 1 year ago

Working nicely on main now.

arouinfar commented 1 year ago

Thanks @Nancy-Salpepi @pixelzoom! I reviewed in Studio and the state wrapper on main and everything looks good. Closing.