search

phetsims / acid-base-solutions

"Acid-Base Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/sims/html/acid-base-solutions/latest/acid-base-solutions_en.html
GNU General Public License v3.0
4 stars 7 forks source link

Should simulationTab.visibleProperty be changed instead of showSolventControl.visibleProperty? #235

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Under the Preferences section of the examples.md it discusses how to remove the Show Solutes control using acidBaseSolutions.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesPanels.simulationPreferencesPanel.simPreferences.showSolventControl.visibleProperty.

Because it is the only sim-specific preference, removing it leaves an empty Simulation tab. Instead should we suggest removing the Simulation tab using acidBaseSolutions.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesTabs.simulationTab.visibleProperty?

sorry @arouinfar...I should have noticed this when I reviewed the examples doc.

Nancy-Salpepi commented 1 year ago

tagging https://github.com/phetsims/qa/issues/975

arouinfar commented 1 year ago

Good catch @Nancy-Salpepi! I thought I had already instructed people to hide the Simulation Tab, but I was thinking of Greenhouse Effect. Fixed in the above commit, closing.