phetsims / alpenglow

Experimental rasterization engine, by PhET Interactive Simulations
MIT License
10 stars 0 forks source link

CT: lint error in ShaderTestUtils.ts #8

Closed pixelzoom closed 10 months ago

pixelzoom commented 10 months ago

On every cycle of CT:

alpenglow : lint
Lint failed with status code 1:
Running "lint" task

/data/share/phet/continuous-testing/ct-main/ct-snapshots/1703211243764/alpenglow/js/webgpu/tests/ShaderTestUtils.ts
21:1 error Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator @typescript-eslint/no-floating-promises

✖ 1 problem (1 error, 0 warnings)

Fatal error: Lint failed
Snapshot from 12/21/2023, 7:14:03 PM
zepumph commented 10 months ago

I believe I actually caused this. Apologies.

zepumph commented 10 months ago

Fixed on the most recent CT

zepumph commented 10 months ago

Caused by the typescript conversion of Namespace over in https://github.com/phetsims/phet-core/issues/133