Local aqua doesn't respect sourcemaps

phetsims / aqua

Automatic QUality Assurance

MIT License

2 stars 4 forks source link

Local aqua doesn't respect sourcemaps #153

Closed samreid closed 2 years ago

samreid commented 2 years ago

Like issue https://github.com/phetsims/chipper/issues/1140 but for local aqua.

@pixelzoom said:

The stack traces for local aqua testing are apparently reporting line numbers in .js files, not in .ts files. Did aqua not received the same source-maps upgrade as CT?

Put a failing assertion in a .ts file, run in aqua. I’m making major changes to RectangularRadioButtonGroup.ts, and here’s what I see:

samreid commented 2 years ago

The committed fix worked well in my testing:

@pixelzoom can you please pull/review/test? Please close if all is well.

pixelzoom commented 2 years ago

Confirmed - it's working great, thanks!