search

phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

Add a single phet-io API check to quick CT #160

Closed jonathanolson closed 1 year ago

jonathanolson commented 2 years ago

GAO + ph-scale should have decent coverage

zepumph commented 1 year ago

Perhaps also tagging @chrisklus because I know he has been working on CTQ recently. Perhaps he has bandwidth for this.

zepumph commented 1 year ago

@KatieWoe just reported a CT problem again:

Several issues are showing Uncaught Error: Assertion failed: Designed API changes detected, please roll them back or revise the reference API:

I'd like to add this to the iteration.

zepumph commented 1 year ago

A non zero exit code will be important for this, see above.

zepumph commented 1 year ago

Ok. This has been added. I ran into trouble on sparky because I didn't support npmUpdate in density. Closing