phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

Rosetta is missing from CTQ #164

Closed liammulh closed 1 year ago

liammulh commented 1 year ago

When I try to search for Rosetta on the CTQ page, this is what I see:

no-rose

This might be related to https://github.com/phetsims/rosetta/issues/366. (I recently merged the development branch for Rosetta 2.0 into the master branch, and there have been a few problems getting it working with CT.) Assigning @zepumph because this doc says he is responsible dev.

@zepumph, if you would like help on this or if you'd like to pair, I am happy to help!

zepumph commented 1 year ago

That filter is for CT in general, If you have tests for rosetta, you may be able to add those to listContinuousTests, but you said there was trouble. I'm not sure I understand what you have already tried, so I don't know what we want to add.

liammulh commented 1 year ago

Sorry, I probably should have tried to provide more context.

CT and CTQ used to show the results of linting Rosetta (both before and after merging the development branch into the master branch). I have Rosetta configured to use PhET's ESLint configurations (both the sim and the Node versions). When I run grunt lint in Rosetta, it passes.

In https://github.com/phetsims/rosetta/issues/366, @samreid and I installed some missing dependencies in Rosetta, and that seemed to fix an error we were getting when we ran Perennial's lint-everything Grunt task.

So at some point, Rosetta seems to have disappeared from CTQ. I can't see Rosetta in CTQ right now:

ctq
zepumph commented 1 year ago

I believe this is a duplicate of https://github.com/phetsims/rosetta/issues/366, please see my response in https://github.com/phetsims/rosetta/issues/366#issuecomment-1438878867.

I do want to note here though that CTQ (quick CT) is just the 5 green/red boxes at the top of the CT report. Everything else below (including the filtering) is normal CT testing.

Feel free to close.

zepumph commented 1 year ago

I'm going to close this, let me know if you want to discuss anything more.